ASoC: max98363: Fix "Unbalanced pm_runtime_enable!" warning #4441
Conversation
Do not call pm_runtime_enable() if it's already enabled. [ 159.241749] PM: resume of devices complete after 879.236 msecs [ 159.244654] max98363 sdw:2:019f:8363:00:1: Unbalanced pm_runtime_enable! [ 159.245100] max98363 sdw:2:019f:8363:00:0: Unbalanced pm_runtime_enable! [ 170.636884] PM: Finishing wakeup. [ 170.636889] OOM killer enabled. [ 170.640395] Restarting tasks ... Signed-off-by: Yong Zhi <[email protected]>
yongzhi1
requested review from
RanderWang,
naveen-manohar and
ryans-lee
as code owners
| @@ -185,7 +185,8 @@ static int max98363_io_init(struct sdw_slave *slave) | |||
| /* make sure the device does not suspend immediately */ | |||
| pm_runtime_mark_last_busy(dev); | |||
|
|
|||
| pm_runtime_enable(dev); | |||
| if (!pm_runtime_enabled(dev)) | |||
There was a problem hiding this comment.
@yongzhi1 this looks a bit fishy with the runtime PM enable sequence and first_hw_init usage here.
There was a problem hiding this comment.
Yes, I agree, if pm_runtime_enable() is called by the codec driver, should there be a matching pm_runtime_disable() called in the same driver?
There was a problem hiding this comment.
@yongzhi1 it's not an issue with pm_runtime_disable() but rather the fact that this entire block is gated by the test on first_hw_init. I don't see how it's possible to execute this block twice.
There was a problem hiding this comment.
Indeed, the above line is called once, and I can repro only once upon reboot with S0ix test "suspend_stress_test -c1"
[ 79.258335] max98363 sdw:2:019f:8363:00:1: Bus clash detected before INT mask is enabled
[ 79.258589] max98363 sdw:2:019f:8363:00:1: Unbalanced pm_runtime_enable!
[ 79.258840] max98363 sdw:2:019f:8363:00:0: Bus clash detected before INT mask is enabled
[ 79.259113] max98363 sdw:2:019f:8363:00:0: Unbalanced pm_runtime_enable!
[ 90.705383] OOM killer enabled.
[ 90.708888] Restarting tasks ..
Will re-test with #4345 and close this one.
|
With #4345, not able to repro two issues:
|
Do not call pm_runtime_enable() if it's already enabled.
[ 159.241749] PM: resume of devices complete after 879.236 msecs [ 159.244654] max98363 sdw:2:019f:8363:00:1: Unbalanced pm_runtime_enable! [ 159.245100] max98363 sdw:2:019f:8363:00:0: Unbalanced pm_runtime_enable! [ 170.636884] PM: Finishing wakeup.
[ 170.636889] OOM killer enabled.
[ 170.640395] Restarting tasks ...