ASoC: don't call trigger ops if the stream is not supported #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plbossart
reviewed
Jun 21, 2023
sound/soc/soc-dai.c
Outdated
| @@ -617,8 +617,14 @@ int snd_soc_pcm_dai_prepare(struct snd_pcm_substream *substream) | |||
| static int soc_dai_trigger(struct snd_soc_dai *dai, | |||
| struct snd_pcm_substream *substream, int cmd) | |||
| { | |||
| struct snd_soc_pcm_stream *stream; | |||
There was a problem hiding this comment.
commit message:
ASoC: soc-dai: don't call trigger ops if the stream is not valid
soc_dai_trigger may be called when the stream is not valid
We should not call the trigger ops in that case to avoid unexpected
behavior or unintended side effects.
soc_dai_trigger may be called when the stream is not valid. We should not call the trigger ops in that case to avoid unexpected behavior or unintended side effects. Signed-off-by: Bard Liao <[email protected]>
bardliao
requested review from
lgirdwood,
ranj063,
kv2019i,
dbaluta,
ujfalusi,
ajitkupandey,
kuanhsuncheng and
yaochunhung
as code owners
ranj063
approved these changes
Jun 22, 2023
juimonen
approved these changes
Jun 22, 2023
plbossart
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
soc_dai_trigger may be called when the stream is not supported. We should not call the trigger ops in that case to avoid unexpect behavior.