SoundWire/hybrid allocation take2 #4428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 67e9dd7. Signed-off-by: Pierre-Louis Bossart <[email protected]>
…lback" This reverts commit c5019e4. Signed-off-by: Pierre-Louis Bossart <[email protected]>
This reverts commit 43bef8b. Signed-off-by: Pierre-Louis Bossart <[email protected]>
This reverts commit f071bff. Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
force-pushed
the
sdw/hybrid-allocation-take2
branch
from
345ad6f
to
fd360c7
Compare
The parameters are only the bus and the device number, manager ops may need additional details on the type of peripheral connected, such as whether it is wake-capable or not. Signed-off-by: Pierre-Louis Bossart <[email protected]>
Rather than add logic in the core for vendor-specific usages, add callbacks for vendor-specific device_number allocation and release. This patch only moves the existing IDA-based allocator used only by Intel to the intel_auxdevice.c file and does not change the functionality. Follow-up patches will extend the behavior by modifying the Intel callbacks. Signed-off-by: Pierre-Louis Bossart <[email protected]>
…tion The IDA-based allocation is useful to simplify debug, but it was also introduced as a prerequisite to deal with the Intel Lunar Lake hardware programming sequences: the wake-ups have to be handled with a system-unique SDI address at the HDaudio controller level. At the time, the restriction introduced by the IDA to 8 devices total seemed perfectly fine, but recently hardware vendors created configurations with more than 8 devices. Add a new allocation strategy to allow for more than 8 devices using information on the type of devices, and only use the IDA-based allocation for devices capable of generating a wake. Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
force-pushed
the
sdw/hybrid-allocation-take2
branch
from
fd360c7
to
0ff2f2f
Compare
|
Only failure is multiple_pause_resume, known firmware issue. |
plbossart
requested review from
RanderWang,
shumingfan,
oder-chiou,
jack-cy-yu and
ryans-lee
as code owners
|
moving back to draft, we have a race condition discussed in #4426 (comment) which needs to be handled first. |
Nothing in the SoundWire specification mandates that the Device Number be constant or fixed. This patch adds a helper to dynamically change the Device Number, either by re-running the bus allocation routine or with a manual override to be used from a debugfs file. Signed-off-by: Pierre-Louis Bossart <[email protected]>
This patch adds support for a debugfs file. Users can read the device number and override the default for stress tests or for convenience, e.g. to make sure devices always have the same device number no matter which order they appear as ATTACHED on the bus. Signed-off-by: Pierre-Louis Bossart <[email protected]>
|
@bardliao I added a tentative helper to change the device number on the fly. I tested it with debugfs this seems to work mostly but there ire issues with interrupts apparently. If you have time to test feedback is welcome. I am not sure how safe this is to change the device_number, if we can't make it work then we have an issue with the IDA stuff, it can be defeated by probe delays |
|
@plbossart I didn't meet the same issue as you. It works when the original dev_num is 6. I verified playback worked after device number changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address upstream feedback from @vinodkoul and add callbacks rather than make the core logic more complicated.
The code is indeed cleaner with fewer if/else cases, and does not keep stuff we no longer need.
Compile-tested only for now.