-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite scroll for multiple images #59
Infinite scroll for multiple images #59
Conversation
@furkankurt Thank you for such a diligently put-together PR. Could you change it so it just contains the infiniteScroll changes? We don't want to update the minimum Dart or Flutter version for this change. Thank you so much. Once that's done, I'm happy to do a code review. Thanks again! |
Hello @jfahrenkrug, thank you for your comment. |
@furkankurt Thanks so much for your great work. All tests pass. I have just one small nitpick request: Could you rename |
@jfahrenkrug thank you, I will update it as soon as I available. |
4c40abf
to
0afaffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you very much.
Thank you @jfahrenkrug, when will you be able to create another release on pub.dev? |
@furkankurt Release is out: https://pub.dev/packages/easy_image_viewer |
Description
By default,
PageView.builder
is infinite in Flutter, unless you provide anitemCount
.I added an option to use the infinite scroll feature for the
EasyImageViewPager
widget.You can use
infiniteScroll: true
to create a "looping" effect with the images. This means that when you reach the end of the image list, you will be taken back to the beginning. This can be useful if you have a small number of images and want to allow the user to scroll through them continuously.This PR covers the closed issue #42
Checklist
Please ensure your pull request fulfills the following requirements:
Type
What kind of change does this pull request introduce?
Breaking Changes
Does this pull request introduce any breaking changes?