Skip to content

Commit

Permalink
Fixed incompatible declaration of Noop::storeContents in php7.2
Browse files Browse the repository at this point in the history
See the reason:

https://3v4l.org/VDT0P

The behavior was changed with this PR: php/php-src#2342 but somehow got left undocumented in upgrade file.
  • Loading branch information
eXtreme authored Jun 5, 2018
1 parent d430e66 commit 3b349d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Storage/Noop.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function rename($path, $newpath)
/**
* {@inheritdoc}
*/
public function storeContents($directory, array $contents, $recursive)
public function storeContents($directory, array $contents, $recursive = false)
{
return $contents;
}
Expand Down

0 comments on commit 3b349d0

Please sign in to comment.