Added SwiftUI app based template #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabiroberai
reviewed
Feb 12, 2022
Co-authored-by: Kabir Oberai <[email protected]>
L1ghtmann
reviewed
Jul 30, 2023
|
Had a couple of comments but this looks good to me otherwise! Awesome work. |
Co-authored-by: Leptos <[email protected]>
|
I believe this is ready now that the launch images and libswift dependency issues were addressed, so I removed the draft status |
Co-authored-by: Kabir Oberai <[email protected]>
Co-authored-by: Leptos <[email protected]>
kabiroberai
requested changes
Jul 31, 2023
leptos-null
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
RootViewController.swifteverytime or just delete all theUITableViewcode and add the basic one aContentView.swiftshould have. Since the AppDelegate lifecycle was abandoned with the introduction of theAppprotocol following iOS 14, I also needed to add the basic code for a file like that, and only then I could start writing the actual code. SwiftUI is also based on structs so it makes sense (to me), having a separate template from the original UIKit one, besides this has become really convenient since I started using it so I thought I'd make a contribution here so everyone can hopefully use it if they wish to.Does this close any currently open issues?
Any relevant logs, error output, etc?
Any other comments?
Where has this been tested?
Operating System: … Kubuntu 22.04.3 LTS x86_64
Platform: …
Target Platform: … iOS/iPadOS
Toolchain Version: … Swift 5.8
SDK Version: … 15.5