Adding Klaxon Instance Variable Name to Home Page & Change Mailer (Issue#70 and Issue#373) #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Move the docker-compose-override.yml file to some other name so that it isn't used automatically for production deployments; create a dev.Dockerfile which mounts the repository in the image, so that docker image builds aren't required each time code changes; start updating DOCKER.md to explain process; remove obsolete docker_example directory.
|
@aandreiu Alexandra, thank you so much for this! I skimmed the code and it looks cool at a glance. We'll give it a close review before we merge. Really appreciate your contribution to the project. We'll also want to add you to our list of contributors at the bottom of our README.md. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I have worked on tackling Issue #70 (adding a variable to say the name of Klaxon instance on home page) and Issue #373 (adding variable name for Klaxon instance to subject line of change mailer).
I added a new environment variable (KLAXON_INSTANCE_NAME) (as an aside, my setting for this value crept into the
docker-compose-dev.ymlfile, but I wasn't sure how the project wanted to handle version control for that kind of thing.)For #70, if set, this value appears in the nav. For #373, I use the same environment variable in the page.html.erb file (messge body) and in the change_mailer.rb file (to set the subject line.)
I tested locally for Issue #70, but ran into some issues testing the Issue #373 since there was no example in the repo for how to test the mailers. I created a new preview file called
change_mailer_preview.rb, located inspec/mailers/previews. @rdmurphy had suggested creating a watched page locally and run the command to check the pages a couple times in order to generate some changes so that the change mailer is triggered. I have not had the opportunity to get this functioning in order to test the change mailer, but I wanted to line up this PR in case I have trouble finishing this after the academic quarter ends.