Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor feature request -- say which install sent a change notification #373

Open
stucka opened this issue Jul 17, 2020 · 5 comments
Open

Comments

@stucka
Copy link
Contributor

stucka commented Jul 17, 2020

I have two Klaxon installs I run mostly for other people and one of them went down for a couple months. I might have noticed sooner, but Klaxon's emails don't tell you which install is triggering a notification. Hovering over the "view source page" button gives an obfuscated link from Sendgrid.

It might be good if notification emails just said somewhere what Klaxon was sending a thing, e.g.:
Something Changed
NTSB boat/car crashes changed. It has changed 134 times since Klaxon started monitoring it on Tuesday, April 30, 2019, at something-klaxon.herokuapp.com.

@tommeagher
Copy link
Member

Thanks, @stucka. This is a cool idea. We'd definitely consider this. There could be spots to customized the navbar for an organization as well.

@aandreiu
Copy link

Hello! My name is Alexandra Andreiu and I am a Masters Student at Northwestern taking on a class centered around making contributions on an open source journalism project for the quarter. I wanted to help with Klaxon, and think that I could help with this issue. Let me know if that would be ok, and whether there is another issue that I could help with as well!

@tommeagher
Copy link
Member

Hi @aandreiu. We'd love to have you contribute to Klaxon (and this class sounds awesome). If you think you can help with this, that'd be great. It looks like this issue might actually be closely related to #70 as well, so it would be worth looking at that. You might be able to fix both at the same time. We gladly accept pull requests.

If you knock this one out and are looking for other issues to tackle, you might want to look at #463, #147 and #111. If you get stuck on anything, please let us know so we can try to help.

@aandreiu
Copy link

Hi @tommeagher! I am working on issue #70 and starting to work on this issue (#373); however, I was wondering if there was any way to test that the new email notification works the way it should? I made some changes locally and wanted to ensure that they are working as intended, but running into the issue of how to trigger the email notification so that I can test it.

@rdmurphy
Copy link
Contributor

Hello @aandreiu! I think what we're missing here is what's called an Action Mailer preview. These live within the spec/mailers/previews directory but it doesn't look like we have one for the ChangeMailer.

I'd probably try to set up a preview for the change emails (I think the docs would get you most of the way there!) then use that generated URL to "see" what a sent email would look like and develop from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants