Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37761 - use ProxyPass and upgrade=websocket where possible #1185

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fixes #37761 - use ProxyPass and upgrade=websocket where possible #1185

merged 1 commit into from
Sep 18, 2024
+96 −42

Commits on Sep 18, 2024

  1. Fixes #37761 - use ProxyPass and upgrade=websocket where possible 

    RewriteRules need special handling of some characters (esp "?"), which
differs based on Apache version. Instead of going down that way, we can
switch to using ProxyPass as proxying is the only thing we really need
here, at least for HTTP.

For WebSockets, we need to allow protocol upgrades, which modern
(2.4.47+) Apache can do itself via "ProxyPass … upgrade=websocket".
For older Apache (esp on EL8 and Ubuntu 20.04), we keep the RewriteRules
in place. To be removed when we drop support for those targets.

Co-Authored-By: Adam Ruzicka <[email protected]>
    @evgeni @adamruzicka
    evgeni and adamruzicka committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    07e773f View commit details
    Browse the repository at this point in the history