Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin FFI to < 1.17 for Ruby 2.7 #387

Merged
merged 1 commit into from
Nov 12, 2024
Merged

pin FFI to < 1.17 for Ruby 2.7 #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ gemspec

gem 'gettext', '>= 3.1.3', '< 4.0.0'

# FFI 1.17 needs rubygems 3.3.22+, which is Ruby 3.0+ only
gem "ffi", "<1.17" if RUBY_VERSION < '3.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we rather use:

Suggested change
gem "ffi", "<1.17" if RUBY_VERSION < '3.0'
gem "ffi", "<1.17" if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3.0')

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, maybe.
But we've used the exact same notation in other places (https://github.com/theforeman/foreman/blob/develop/Gemfile#L55) and it works fine.


group :test do
gem 'rake'
gem 'thor'
Expand Down
Loading