Fixes #36312 - Remove toast alert for register host validation #9688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Issues: #36312 |
ekohl
requested changes
Apr 18, 2023
There was a problem hiding this comment.
Please get used to https://cbea.ms/git-commit/#imperative for the commit message. This means Remove alert ... and not Removed.
girijaasoni
changed the title
stejskalleos
requested changes
Apr 19, 2023
Ron-Lavi
reviewed
Apr 19, 2023
...scripts/react_app/routes/RegistrationCommands/RegistrationCommandsPage/components/Actions.js
Show resolved
Hide resolved
Ron-Lavi
approved these changes
Apr 27, 2023
stejskalleos
approved these changes
Apr 28, 2023
|
@girijaasoni can we merge, or are there going to be more changes? |
|
@ekohl any other comments or can we merge? |
we can merge it |
ekohl
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in reference to Katello PR:
Katello/katello#10518
This is to remove the alert toast on register host page