move some ansible-free code to apypie #1789
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
the-refactoring
branch
9 times, most recently
from
4e78098
to
9a2b637
Compare
evgeni
force-pushed
the
the-refactoring
branch
2 times, most recently
from
3dd17c4
to
ef6595f
Compare
ekohl
reviewed
Oct 28, 2024
plugins/module_utils/_apypie.py
Outdated
Comment on lines
1038
to
1039
| PER_PAGE = 2 << 31 | ||
| payload = {'per_page': PER_PAGE} |
There was a problem hiding this comment.
Foreman supports per_page=all, but Katello has its own mechanism using full_result=true. I started Katello/katello#11126 to unify this, but I don't think that's ready to be merged any time soon.
|
|
||
| if search is not None: | ||
| params['search'] = search | ||
| params['per_page'] = PER_PAGE |
There was a problem hiding this comment.
The constant definition is now unused.
There was a problem hiding this comment.
That's not correct ;)
plugins/modules/activation_key.py:from ansible_collections.theforeman.foreman.plugins.module_utils.foreman_helper import KatelloEntityAnsibleModule, PER_PAGE
efd64bc
to
8121f36
Compare
evgeni
force-pushed
the
the-refactoring
branch
from
8121f36
to
9adb24b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.