Improvements #3
Open
Improvements #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometime it's better to manage DNS on other levels
For paranoinds like myself who can't trust some alien AMI
Feels like overkill for a task, starting one instance from scratch with one docker container shouldn't require AMI baking.
Separate filename form prefix to allow clear backup/restore workflow
For small deployments when starting separate host for docker slave feels like overkill
Will be usefull for docker images
|
Great additions here! I would add them to the base template as they follow best practices. The only thing I wouldn't do is to delete the master key after launch. |
|
Permissions on master key is too wide, i'd suggest you at least make it optional to delete master key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I made a lot of small improvements to your template. Some of them contradict with best practices, others are really essential.
Would you be interested in pull request?