Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add closing Div to Toast #46

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

joshcirre
Copy link
Contributor

Livewire was throwing an "unclosed bracket" error originating from the toast component.

This PR adds the closing Div to the functional and class based stubs.

Copy link

what-the-diff bot commented Jul 6, 2024

PR Summary

  • Improved code structure in stubs/class directory
    An additional closing element has been added to the file toast.blade.php in the stubs/class directory. This improves the HTML structure of this file and ensures that there are no unclosed elements that could potentially lead to behavior inconsistencies or HTML parsing errors.

  • Enhanced HTML integrity in stubs/default directory
    Similarly, the toast.blade.php file in the stubs/default directory has also received a closing tag. This will contribute to an improved HTML structure and a smoother rendering of the respective content.

@tnylea
Copy link
Contributor

tnylea commented Jul 13, 2024

You da man 👏

Thanks for this fix 😉

@tnylea tnylea merged commit 2ae630a into thedevdojo:main Jul 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants