WIP: Add support for EKS #12
Conversation
if we don't have a provider, assume it's gke unbreak existing tests, still need to add new tests
| "github.com/thecasualcoder/kube-tmuxp/pkg/filesystem" | ||
| "github.com/thecasualcoder/kube-tmuxp/pkg/kubeconfig" | ||
| "github.com/thecasualcoder/kube-tmuxp/pkg/kubetmuxp" | ||
| "github.com/jfreeland/kube-tmuxp/pkg/commander" |
There was a problem hiding this comment.
Imports should not be changed. Can we keep it as before ?
There was a problem hiding this comment.
Doh! Sorry about that.
I could certainly change this and check it in as-is, but I wasn't sure if this really matched how you would want to approach this? If so, I'll clean up and push.
I think I had in mind that I should go back and by default specify that default provider is gke if no provider is specified so that it's backwards compatible.
But then again I started thinking there might be another/better ways to do this if you wanted to also add other providers.
At the time, I just did what I needed to scratch my specific itch. :)
Thoughts?
There was a problem hiding this comment.
I've not seen the full code. Will have a look and let you know soon
I used kube-tmuxp for a while and loved it. I've recently started using EKS more and missed it. I'd like to see basic support for EKS added to kube-tmuxp.
This is a very rough first attempt to add some support for EKS in addition to GCP.
I have not fixed tests yet and I'm not even sure if this is how you would approach this; I just did something simple and lazy for now. If you'd like to consider adding this, I can clean it up per your feedback.
On the other hand, it scratches my itch for the moment. 🤷♂