Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added shorty zero json #2355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added shorty zero json #2355

wants to merge 1 commit into from

Conversation

axshae
Copy link

@axshae axshae commented Oct 23, 2024 •
edited by Cipulot
Loading

Description

QMK Pull Request

VIA Keymap Pull Request

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link
Collaborator

Cipulot commented Oct 24, 2024

I went on and unticked all the PR checklist..... It clearly wasn't followed at all

@Cipulot Cipulot added the invalid This doesn't seem right label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axshae @Cipulot