Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dnworks SBL to dnworks 60percent #2293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

itsme-zeix
Copy link
Contributor

Description

I renamed the JSON file and folder from "sbl" to "60percent" due to electronically identical PCBs. For QMK, this renaming was done in the "develop" branch, which has been approved. However, I don't anticipate it will be merged soon (qmk/qmk_firmware#23683).

Would it be more appropriate to revert the changes to the file and folder names, and instead only change the "name" field in the JSON file first? That could serve as a temporary solution until the QMK pull request is merged.

QMK Pull Request

qmk/qmk_firmware#23683

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@Xelus22
Copy link
Collaborator

Xelus22 commented May 31, 2024

I think just leave it for now and wait for the merge. This would be purely cosmetic anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants