Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for keyboard nico from neson design #1969

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Conversation

yulei
Copy link
Contributor

@yulei yulei commented Jul 26, 2023

Description

added support for nico

QMK Pull Request

#20686

qmk/qmk_firmware#20686

Checklist

  • [ x] The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • [x ] The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • [x ] I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • [x ] I have tested this keyboard definition using VIA's "Design" tab.
  • [x ] I have tested this keyboard definition with firmware on a device.
  • [ x] I have assigned alpha keys and modifier keys with the correct colors.
  • [x ] The Vendor ID is not 0xFEED

Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yulei
Copy link
Contributor Author

yulei commented Jul 30, 2023

https://www.caniusevia.com/docs/layouts#kle-json-rules

Please colour in the KLE

color was added.

@Xelus22 Xelus22 merged commit 530511b into the-via:master Jul 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants