Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keymap for MOTHWING #1950

Merged
merged 3 commits into from
Aug 5, 2023
Merged

Add keymap for MOTHWING #1950

merged 3 commits into from
Aug 5, 2023

Conversation

tan-t
Copy link
Contributor

@tan-t tan-t commented Jul 12, 2023 •
edited by Xelus22
Loading

Description

added a keymap for "MOTHWING" keyboard.

QMK Pull Request

qmk/qmk_firmware#19342
(reviewed, but not merged yet)

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Xelus22
Xelus22 requested changes Jul 15, 2023
View reviewed changes
Copy link
Collaborator

@Xelus22 Xelus22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove V2 definition as that is only legacy support boards (src/ folder)

v3/mothwing/mothwing.json Outdated Show resolved Hide resolved
@tan-t
Copy link
Contributor Author

tan-t commented Jul 19, 2023 •
edited
Loading

Please remove V2 definition as that is only legacy support boards (src/ folder)

I see

@tan-t
Copy link
Contributor Author

tan-t commented Jul 19, 2023

@Xelus22
sorry for the late reply.
I deleted legacy settings, and deleted customKeycodes (that was for testing, I forgot to delete it)

@tan-t tan-t requested a review from Xelus22 July 28, 2023 01:05
@tan-t
Copy link
Contributor Author

tan-t commented Jul 28, 2023

@Xelus22 sorry to bother you, but can you have it merged by the end of July? thanks!

Xelus22
Xelus22 requested changes Jul 29, 2023
View reviewed changes
v3/mothwing/mothwing.json Outdated Show resolved Hide resolved
@tan-t
Copy link
Contributor Author

tan-t commented Aug 3, 2023

@Xelus22 Hi! I think I resolved all the request for changes. could you check it? thanks!

@tan-t tan-t requested a review from Xelus22 August 4, 2023 13:52
@tan-t
Copy link
Contributor Author

tan-t commented Aug 4, 2023

@Xelus22 I'm really sorry to bother you but can you merge it soon? my first copies will be arrived tommorrow or something.
I'm really sorry but if you could merge it soon I will appreciate it. thank you

@Xelus22 Xelus22 merged commit 7aab3f4 into the-via:master Aug 5, 2023
2 checks passed
@tan-t tan-t mentioned this pull request Aug 5, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xelus22 Xelus22 Xelus22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tan-t @Xelus22