Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Dreft] Improving accessibility of some UI Components. #268

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ungjinPark
Copy link

What's changes?

  • Implement keyboard navigation for some MenuContainer Items
  • Add accessibility attributes(WAI-ARIA) for MenuContainer Items and MenuContainer
  • Add role='link' and aria-current="page" for main tablist(Configure, Key tester, etc)
  • Add a button role, tabindex, aria-pressed state, and also add aria-label per each key in Configure tab that keyboard loaded(two-string: 2d keyboard screen)
  • Add a switch role for checkbox on the settings screen
  • Add attribute, 'htmlFor" to some unassigned label elements for input tag.

Suggestion

I want to make it accessible for various people likes visually impaired.

Around me, there are a lot of blind friends who like to using and collecting mechanical keyboards. But they can't use it because the most components are not accessible from screen readers.

I think this application has the potential to be accessible to various people if some features are implemented.

Unfortunately I'm not good at React and I'm not good at speaking, writing English.

But, I worked for web accessibility five years ago. If you ask me about various accessibility implementation. I can be helpful to that.

Can you help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant