-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Herokuize project #54
base: master
Are you sure you want to change the base?
Conversation
410ac83
to
543e1f7
Compare
* add build step to project * add dev script * instruct to use DATABASE_URL * put morgan in dependencies * inspired by https://github.com/babel/example-node-server/blob/master/package.json
I updated this pr to have the server restart via nodemon when the source changes. And the start script builds the server before serving. |
Why? The changes required to make the api run without issues in heroku do not prevent you from running it locally. These changes are just following best practices imo |
Thanks for your changes @morenoh149 I will take this change into account once I rewrite the tutorial for this application. Thanks for your help here 👍 |
@morenoh149 I get the following error for this PR when I try to deploy it to Heroku: 2019-07-08T15:57:30.637694+00:00 heroku[web.1]: Starting process with command |
that's javascript complaining that |
@morenoh149 - I only did git clone and npm install. |
@ACPK this repo was not developed to work on heroku, that is why I opened this issue because I thought running on heroku would be useful. |
fixes #37