Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

Disable DjangoQL 0.14 advanced search syntax by default. #716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grembo
Copy link
Contributor

@grembo grembo commented Jan 14, 2021

DjangoQL 0.14 enables advanced search/completion by default. This patch
disables it again, so paperless behaves the same regardless of the
version used.

See

When using DjangoQL 0.13, this is simply a NOOP.

DjangoQL 0.14 enables advanced search/completion by default. This patch
disables it again, so paperless behaves the same regardless of the
version used.

See
- https://github.com/ivelum/djangoql/blob/master/CHANGES.rst#0140
- https://github.com/ivelum/djangoql#using-djangoql-with-the-standard-django-admin-search

When using DjangoQL 0.13, this is simply a NOOP.
@MasterofJOKers
Copy link
Contributor

It seems like we're still on 0.12.3. Is it a NOOP there, too?

Would it make sense to expose this as a setting, so the user can choose whether they want djangoql by default or not?

@grembo
Copy link
Contributor Author

grembo commented Jan 14, 2021

It seems like we're still on 0.12.3. Is it a NOOP there, too?

Yes, it only sets a class variable, which in case of older versions is simply ignored by DjangoQL, as it's unknown to those.

Would it make sense to expose this as a setting, so the user can choose whether they want djangoql by default or not?

Maybe once you upgraded your preferred version to 0.14 (I'm maintaining the FreeBSD port, which uses latest versions by default, that's why I stumbled over this problem)? AFAIK the tunable isn't available in earlier versions and would have to be emulated by setting it explicitly for those, probably not worth the effort.

uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jan 15, 2021
Document search field was broken.

See
the-paperless-project/paperless#716


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@561675 35697150-7ecd-e111-bb59-0022644237b5
uqs pushed a commit to freebsd/freebsd-ports that referenced this pull request Jan 15, 2021
Jehops pushed a commit to Jehops/freebsd-ports-legacy that referenced this pull request Jan 16, 2021
Document search field was broken.

See
the-paperless-project/paperless#716


git-svn-id: svn+ssh://svn.freebsd.org/ports/head@561675 35697150-7ecd-e111-bb59-0022644237b5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants