Closes #22

thamara · Sep 25, 2019 · dca4f8d · dca4f8d
1 parent 149b07c
commit dca4f8d
Showing 1 changed file with 25 additions and 6 deletions.
diff --git a/js/calendar.js b/js/calendar.js
@@ -206,17 +206,18 @@ class Calendar {
     _initCalendar() {
         this._generateTemplate();
         this.updateBasedOnDB();
-        this.updateLeaveBy();
-        $('input[type=\'time\']').on('input propertychange', function() {
-            updateTimeDayCallback(this.id, this.value);
-        });
-
+
         if (!showDay(this.today.getFullYear(), this.today.getMonth(), this.today.getDate())) {
             document.getElementById('punch-button').disabled = true;
         } else {
             document.getElementById('punch-button').disabled = false;
         }
 
+        this.updateLeaveBy();
+        $('input[type=\'time\']').on('input propertychange', function() {
+            updateTimeDayCallback(this.id, this.value);
+        });
+
         $('#punch-button').on('click', function() {
             punchDate();
         });
@@ -339,8 +340,8 @@ class Calendar {
             this.today.getFullYear() != this.getYear()) {
             return;
         }
+        var [dayBegin, lunchBegin, lunchEnd, dayEnd] = getDaysEntriesFromHTML(this.today.getFullYear(), this.today.getMonth(), this.today.getDate());
         var dayKey = this.today.getFullYear() + '-' + this.today.getMonth() + '-' + this.today.getDate() + '-';
-        var dayBegin = document.getElementById(dayKey + 'day-begin').value;
         if (validateTime(dayBegin)) {
             var leaveBy = sumTime(dayBegin, getHoursPerDay());
             var lunchTotal = document.getElementById(dayKey + 'lunch-total').value;
@@ -351,6 +352,13 @@ class Calendar {
         } else {
             document.getElementById('leave-by').value = '';
         }
+
+        if (dayBegin.length && lunchBegin.length && lunchEnd.length && dayEnd.length) {
+            //All entries computed
+            document.getElementById('punch-button').disabled = true;
+        } else {
+            document.getElementById('punch-button').disabled = false;
+        }
     }
 
     /*
@@ -501,6 +509,17 @@ function getDaysEntries(year, month, day) {
         store.get(dayStr + 'day-end')];
 }
 
+/*
+ * Returns the entries for the day, from HTML (for performance).
+ */
+function getDaysEntriesFromHTML(year, month, day) {
+    var dayStr = year + '-' + month + '-' + day + '-';
+    return [document.getElementById(dayStr + 'day-begin').value,
+        document.getElementById(dayStr + 'lunch-begin').value,
+        document.getElementById(dayStr + 'lunch-end').value,
+        document.getElementById(dayStr + 'day-end').value];
+}
+
 function colorErrorLine(year, month, day, dayBegin, lunchBegin, lunchEnd, dayEnd) {
     var trID = ('tr-' + year + '-' + month + '-' + day);
     if (hasInputError(dayBegin, lunchBegin, lunchEnd, dayEnd)) {