Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: enhance [SKIP EXISTING FILES] feature to include files that arent downloaded from youtube-music #2543

Open
2 tasks done
kingmadwik opened this issue Oct 23, 2024 · 3 comments

Comments

@kingmadwik
Copy link

kingmadwik commented Oct 23, 2024

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

I have some files that have time synced lyrics ( i synced them by myself). Now i want to keep using those files as well as download new ones but some old tracks are also present in my playlists on youtube. When i batch download playslist, even If i use [skip existing file] feature on youtube-music app downloads files i already have and that makes me end up with two files of same track but also new files dont have lyrics in them (i plan to use them for offline listening).

Proposed Solution

Add a filter that can identify if the same or similar song is already present in the downlaod directory and stop downlaoding such a track.

Alternatives Considered

Alternative would be to add lyrics embedded into metadata of the song itslef while downloading, given you also plan to include multiple lyrics sources. or the least of all make time synced lyrics with time stamps be available to be copied to clipboard like how (SONG SYNC android app on fdroid does ) so we can manually copy and update metadata 🤝

Additional Information

Maybe im asking too much, thanks for your work devs

@ArjixWasTaken
Copy link
Contributor

The downloader needs a lot of rework not gonna lie, so I'll put this on my TODO for after I am done with synced-lyrics.

@kingmadwik
Copy link
Author

@ArjixWasTaken Can you tell me if theres a way to adjust how to customize file name before i download the track ? If there isnt can you add that feature in upcoming releases. I dont know how to code but can follow instructions if i have an option to implement it now.

Also if youtube supports only 128kbps OPUS for free account, and mp3 file from youtube-music is 256kbps when downloaded, so is it same as mp3 128kbps for same file from somewhere else. i dont know much about audio codecs, formats. Is it because you convert from opus to mp3 that its bitrate increases? is it possible for you to make the file we download a 128kbps MP3 because i didnt hear much difference in detail between the same file for a 128kbps vs 256kbps MP3? maybe its my headphones but just want to know the difference

@ArjixWasTaken
Copy link
Contributor

@kingmadwik not gonna work on this now, but from the looks of it, it ain't a thing yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants