Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown implementation which hooks into /world/Del #155

Closed
wants to merge 3 commits into from
Closed

Shutdown implementation which hooks into /world/Del #155

wants to merge 3 commits into from

Conversation

ZephyrTFA
Copy link
Contributor

Add shutdown handling for rust-g

Move log closing to said proc.
Implement job detaching for said proc.

dmsrc/log.dm Show resolved Hide resolved
@ZephyrTFA ZephyrTFA closed this Oct 29, 2023
@ZephyrTFA ZephyrTFA reopened this Oct 29, 2023
@AffectedArc07
Copy link
Member

Wonder if this would fix our need to have a patch on the HTTP client that has a designated create and shutdown method.

dmsrc/world.dm Show resolved Hide resolved
@optimumtact
Copy link
Member

where do they go when they get detatched.

@ZephyrTFA
Copy link
Contributor Author

where do they go when they get detatched.

No where, we just drop our reference to them which means that they become free standing threads. There's no easy way to hook cancelation logic in and leaving them orphaned won't cause any problems

@ZephyrTFA ZephyrTFA requested a review from ZeWaka October 30, 2023 10:24
@willox
Copy link
Contributor

willox commented Oct 30, 2023

"Detaching" the threads would mean they may still exist after the module is unloaded which will result in a crash. It doesn't do anything.

TLS destructors on module unload should already result in all of these handles being dropped, has some kind of problem with that been found?

@ZephyrTFA ZephyrTFA closed this by deleting the head repository Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants