Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mysql use the native rust tls stack by default #144

Merged
merged 5 commits into from
Jul 22, 2023
Merged

Make mysql use the native rust tls stack by default #144

merged 5 commits into from
Jul 22, 2023

Conversation

optimumtact
Copy link
Member

This removes the dependency on libssl, which is one of the few remaining dependencies that it has beyond libc

This is a major version bump because there may be some inconsistencies with the tls certs suported by rustls

https://docs.rs/mysql/latest/mysql/#ssl-support

You can opt back into the native stack if you so choose

@optimumtact
Make mysql use the native rust tls stack by default
950c1a2 
This removes the dependency on libssl, which is one of the few remaining
dependencies that it has beyond libc

This is a major version bump because there may be some inconsistencies
with the tls certs suported by rustls

https://docs.rs/mysql/latest/mysql/#ssl-support

You can opt back into the native stack if you so choose
@optimumtact
Copy link
Member Author

optimumtact commented Jul 17, 2023 •
edited
Loading

can anyone explain to me why cargo is ignoring the updated cargo lock file for the windows build?

Or more accurately, why is the windows build locked while the linux ones are not?

@optimumtact
Workaround for having mutually exclusive features
b3012a5 
We add a target that provides "all" features that are all the relevant
buildable features that are not mutually exclusive
@ZeWaka
Copy link
Contributor

ZeWaka commented Jul 18, 2023

heh I had a branch for this but got busy, will review soon

@AffectedArc07
Copy link
Member

This is hot

ZeWaka
ZeWaka approved these changes Jul 19, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
ZeWaka
ZeWaka reviewed Jul 19, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
@san7890 san7890 mentioned this pull request Jul 21, 2023
Merged
@ZeWaka ZeWaka merged commit 36e6613 into master Jul 22, 2023
2 checks passed
@ZeWaka ZeWaka deleted the begone_libssl_you_are_banished branch July 22, 2023 23:24
@ZeWaka ZeWaka mentioned this pull request Jul 23, 2023
Merged
itsmeow pushed a commit to itsmeowForks/rust-g that referenced this pull request Dec 28, 2023
@optimumtact @itsmeow
Make mysql use the native rust tls stack by default (tgstation#144)
db877ce
itsmeow added a commit to BeeStation/rust-g that referenced this pull request Dec 28, 2023
@itsmeow @ZephyrTFA
@optimumtact @ZeWaka @DTraitor @silicons @Absolucy @AffectedArc07 @Kapu1178 @vvvv-vvvv
Update to latest + IconForge (#11)
1b1bbec 
* Update time.dm (tgstation#130)

* Bump version major, due to breaking change in tgstation#130

* Try to fix the dependency issue

* Upgrade a bunch of dependencies (tgstation#134)

* Upgrade base64 to 0.21

* bump toml to 0.7.4

* Upgrade pathfinding to 4.2.1

* Upgrade git2 to 0.17.1

* update mysql crate to 24.0

* aho-corasic upgrade to 1.0 pt A
"automatic configuration is now the default."

* upgrade ahocorasic pt B

* Adds a redis reliable queue implementation (tgstation#133)

* adds project to vscode rust-analyzer config
it asked me to

* redis reliable queue implementation

* readme

* cleanup

* shit fixed

* proper redis response handling for lpop

* more clean

* okay better handling i GUESS

* updated redis crate, all my tests pass
breaking changes don't apply either

* update the cargo lock to 2.0.0

* ignore clippy for the redis_lpush match return

* fixes cellularnoise clippy lints

* dmi_strip_metadata won't remove alpha channel anymore (tgstation#136)

* pedantic and nursery clippy lints (tgstation#137)

* June `cargo update` (tgstation#138)

* `cargo update`

* update `const-random` to 0.1.15
(nothingburger change)

* Update the url packages (percent-encoding and url)
(still nothingburger)

* dashmap to 5.4

* rayon to 1.7

* Stop using deprecated chrono func (would panic)

* run `cargo update` again
apparently a lot of things did some releases

* put the once_cell version to 1.17

for some reason i missed it, ooops

* 2.0.1 (tgstation#139)

* add uniform precision to rust-g timestamp (tgstation#141)

* add precision to rust-g timestamp

* coping

* adds rustg_dmi_icon_states (tgstation#140)

* 2.1.0 (tgstation#143)

* Make mysql use the native rust tls stack by default (tgstation#144)

* 3.0.0 (tgstation#147)

* Some routine updates for 3.0.0 (tgstation#152)

routine package maintenance and upgrades - i went through the breaking changes and didn't see anything that looked like it affected us, only additions to public apis really

* Use gitoxide rather than libgit2 for the git module (tgstation#156)

* Adds Base64 decoding stuff (tgstation#154)

* More routine updates (tgstation#157)

* Updates `rustg_file_exists()` macro to remove user error (tgstation#158)

* Last little bit of updates (tgstation#159)

* v3.1.0 (tgstation#161)

* pathfinder: fix typo in rustg_remove_node_astar (tgstation#162)

* pathfinder: stringify args expecting numbers (tgstation#163)

* Re-add all features release builds

* Label linux builds

* IconForge

Start blending

Huge cleanup

Finish optimizing the thing

Finish the thing!!

Clean up a bit

Re-add 32-bit thing

Fix TOML sorting

Add dmsrc

Fix clippy suggestions

Clippy.. stop being mean

Cargo fmt + doc comments

Code cleanup

More cleanup, remove most unsafe unwrap()s, use Match syntax.

Remove unneccesarily verbose casting

Fix overlay blending

Cleanup with new DMI version

Cargo fmt

Leaf test, DynamicImage->RgbaImage, better Error handling, DashMap, and cleanup command

Fix

Further tree optimizations, hashing optimization, cache icostrings more effectively.

Optimize unique_icons insertion a little

Fix macro

Little more cleanup

Add to README

Update dmi, add caching logic.

Address reviews

Cleanup panic unwind

Fix lint failure

---------

Co-authored-by: Zephyr <[email protected]>
Co-authored-by: oranges <[email protected]>
Co-authored-by: ZeWaka <[email protected]>
Co-authored-by: DTraitor <[email protected]>
Co-authored-by: silicons <[email protected]>
Co-authored-by: Lucy <[email protected]>
Co-authored-by: AffectedArc07 <[email protected]>
Co-authored-by: Kapu1178 <[email protected]>
Co-authored-by: vvvv-vvvv <[email protected]>
FluffyGhoster pushed a commit to FluffyGhoster/aurora-rust-g that referenced this pull request Mar 24, 2024
@optimumtact @FluffyGhoster
Make mysql use the native rust tls stack by default (tgstation#144)
08ce515
FluffyGhoster added a commit to FluffyGhoster/aurora-rust-g that referenced this pull request Mar 24, 2024
@FluffyGhoster
Squashed commit of the following:
eecaae7 
commit 4aff57f
Author: vvvv-vvvv <[email protected]>
Date:   Sun Dec 24 00:39:30 2023 +0000

    pathfinder: stringify args expecting numbers (tgstation#163)

commit c3313a1
Author: vvvv-vvvv <[email protected]>
Date:   Sun Dec 24 00:31:03 2023 +0000

    pathfinder: fix typo in rustg_remove_node_astar (tgstation#162)

commit 79f04b1
Author: ZeWaka <[email protected]>
Date:   Sat Dec 23 13:15:10 2023 -0800

    v3.1.0 (tgstation#161)

commit bf20ba0
Author: ZeWaka <[email protected]>
Date:   Sat Dec 23 01:04:28 2023 -0800

    Last little bit of updates (tgstation#159)

commit 50f36fa
Author: Kapu1178 <[email protected]>
Date:   Sat Dec 23 03:17:11 2023 -0500

    Updates `rustg_file_exists()` macro to remove user error (tgstation#158)

commit 75a6384
Author: ZeWaka <[email protected]>
Date:   Sat Dec 16 18:57:46 2023 -0800

    More routine updates (tgstation#157)

commit 9cfa350
Author: AffectedArc07 <[email protected]>
Date:   Sun Dec 17 02:55:52 2023 +0000

    Adds Base64 decoding stuff (tgstation#154)

commit b964c87
Author: Lucy <[email protected]>
Date:   Sat Dec 16 20:47:38 2023 -0500

    Use gitoxide rather than libgit2 for the git module (tgstation#156)

commit 85631fa
Author: ZeWaka <[email protected]>
Date:   Mon Sep 25 13:38:15 2023 -0700

    Some routine updates for 3.0.0 (tgstation#152)

    routine package maintenance and upgrades - i went through the breaking changes and didn't see anything that looked like it affected us, only additions to public apis really

commit cd741e9
Author: ZeWaka <[email protected]>
Date:   Sat Jul 22 17:48:26 2023 -0700

    3.0.0 (tgstation#147)

commit 36e6613
Author: oranges <[email protected]>
Date:   Sun Jul 23 11:24:42 2023 +1200

    Make mysql use the native rust tls stack by default (tgstation#144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeWaka ZeWaka ZeWaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@optimumtact @ZeWaka @AffectedArc07