Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(base-cluster/tracing): apparently tempo changed their service name #555

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

cwrau
Copy link
Member

@cwrau cwrau commented Sep 8, 2023

Closes #554

@tasches tasches force-pushed the fix/base-cluster-otel-trace-config branch from a000df3 to 3172350 Compare September 12, 2023 09:49
Copy link
Collaborator

@tasches tasches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. It fixes the issue

@cwrau cwrau merged commit a3b1cf0 into main Sep 12, 2023
8 checks passed
@cwrau cwrau deleted the fix/base-cluster-otel-trace-config branch September 12, 2023 10:06
@teutonet-bot
Copy link
Contributor

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/rbac-values.yaml has no changes

[charts/base-cluster/ci/imagepullsecrets-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id='container'>
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters.
    <hr>
    <p>
        Something unexpected? Please create a <a href='https://dpaste.freshdesk.com/support/tickets/new'>support ticket</a>.
    </p>
</div>
<p>
    <a class='button' href='/' onclick='history.back();return false;'>Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>
)

charts/base-cluster/values.yaml has no changes

charts/base-cluster/ci/artifacthub-values.yaml

charts/base-cluster/ci/flux-gitrepositories-values.yaml has no changes

charts/base-cluster/ci/basic-values.yaml has no changes

charts/base-cluster/ci/velero-backupStorageLocations-values.yaml has no changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[base-cluster/tracing] grafana tempo distributor not working
3 participants