Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added commands in CI for building docker images when merged #57

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Added commands in CI for building docker images when merged #57

merged 4 commits into from
Jul 7, 2023

Conversation

marrts
Copy link
Contributor

@marrts marrts commented Jul 6, 2023

No description provided.

@marrts
Copy link
Contributor Author

marrts commented Jul 6, 2023

Apparently I did something wrong because now the Foxy and Humble CI's aren't even running.

@marip8
Copy link
Contributor

marip8 commented Jul 6, 2023

Invalid workflow file: .github/workflows/jammy_build.yml#L80
The workflow is not valid. .github/workflows/jammy_build.yml (Line: 80, Col: 17): Unrecognized named-value: 'ROS_DISTRO'. Located at position 1 within expression: ROS_DISTRO

@marip8
Copy link
Contributor

marip8 commented Jul 6, 2023

Click on to Checks -> <Build Name> to see the error message from jobs that don't run

@marrts
Copy link
Contributor Author

marrts commented Jul 6, 2023

Click on to Checks -> <Build Name> to see the error message from jobs that don't run

Thanks! That error makes sense now that I see it.

@marip8
Copy link
Contributor

marip8 commented Jul 6, 2023 •
edited
Loading

If you're working on the CI build, I would suggest changing it to a matrix build for Ubuntu systems like here. IMO it's worth losing the separate build badge to be able to have a single file that runs builds for all desired Ubuntu distros

@marip8 marip8 merged commit aa9597e into tesseract-robotics:master Jul 7, 2023
5 checks passed
@marrts marrts mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marip8 marip8 marip8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marrts @marip8