Fix Mac OS clang compiler warnings #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
- Coverage 84.73% 84.73% -0.01%
==========================================
Files 231 231
Lines 15725 15724 -1
==========================================
- Hits 13324 13323 -1
Misses 2401 2401 |
|
The tests are failing but the action is not returning an error. |
Levi-Armstrong
approved these changes
Jul 31, 2024
|
I am not sure why the tests are failing on GitHub. They are passing locally. Let's merge these updates and open an issue. |
Levi-Armstrong
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some clang warnings on Mac OS. This will require tesseract-robotics/trajopt#418 to pass the CI tests.