Fix Windows and Mac OS Github Actions #489
Conversation
|
Windows will not automatically export Either we need to manually export these symbols or use something other than |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 84.81% 84.81%
=======================================
Files 231 231
Lines 15737 15737
=======================================
Hits 13347 13347
Misses 2390 2390 |
I will add the export header and export the static variables. |
…act_planning into win-mac-action
…Levi-Armstrong/tesseract_planning into win-mac-action2
…act_planning into win-mac-action
|
It looks like the Mac OS build is going to need more upstream fixes. Let's merge this for now to get the Windows fixes. |
|
Why do you have to generate export file for each library? The files are identical except the name of the variable. Could we not just generate one for the core library and use it for everything? |
| @@ -60,3 +60,4 @@ jobs: | |||
| upstream-args: --cmake-args -G "Ninja" -DVCPKG_TARGET_TRIPLET=x64-windows-release -DCMAKE_BUILD_TYPE=Release -DBUILD_IPOPT=OFF -DBUILD_SNOPT=OFF -DTESSERACT_BUILD_TRAJOPT_IFOPT=OFF -DVCPKG_APPLOCAL_DEPS=OFF | |||
| target-path: target_ws/src | |||
| target-args: --packages-ignore tesseract_examples --cmake-args -G "Ninja" -DVCPKG_TARGET_TRIPLET=x64-windows-release -DCMAKE_BUILD_TYPE=Release -DTESSERACT_ENABLE_TESTING=ON -DTESSERACT_BUILD_TRAJOPT_IFOPT=OFF -DVCPKG_APPLOCAL_DEPS=OFF | |||
| run-tests-args: --packages-ignore tesseract_examples | |||
There was a problem hiding this comment.
What is the current issue with the examples?
There was a problem hiding this comment.
I haven't cleaned up the examples for Windows. I don't want to spend the time right now to work on them.
Each individual DLL needs to have its own import/export since they may reference each other. |
|
I have the Mac OS working but I need to merge this pull request and a few others in different places. |
Levi-Armstrong
merged commit b321b52
into
tesseract-robotics:master
No description provided.