-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new task composer plugin factory constructor #370
Add new task composer plugin factory constructor #370
Conversation
Not sure what happened to the taskflow library on Focal; the stable job fails because it can't install taskflow |
Can you add a unit test which covers the new code? |
It should get it from here: https://launchpad.net/~ros-industrial/+archive/ubuntu/ppa/+packages |
Actually it can also get it from ros: https://repositories.ros.org/status_page/ros_noetic_default.html?q=taskflow |
@marip8 It looks like something might have changed with github CI because the the add_source.sh which adds the ppa to allow installing taskflow is failing. 2023-08-28T13:08:14.4601529Z �[1m$ ( ./.github/workflows/add_sources.sh; )�[0m
2023-08-28T13:08:14.4601720Z
2023-08-28T13:08:14.4601836Z Reading package lists... 0%
2023-08-28T13:08:14.4602001Z
2023-08-28T13:08:14.4602110Z Reading package lists... 0%
2023-08-28T13:08:14.4602267Z
2023-08-28T13:08:14.4602373Z Reading package lists... 0%
2023-08-28T13:08:14.4602533Z
2023-08-28T13:08:14.4602807Z Reading package lists... 4%
2023-08-28T13:08:14.4602955Z
2023-08-28T13:08:14.4603064Z Reading package lists... 4%
2023-08-28T13:08:14.4603221Z
2023-08-28T13:08:14.4603483Z Reading package lists... 4%
2023-08-28T13:08:14.4603869Z
2023-08-28T13:08:14.4603976Z Reading package lists... 4%
2023-08-28T13:08:14.4604135Z
2023-08-28T13:08:14.4604461Z Reading package lists... 45%
2023-08-28T13:08:14.4604633Z
2023-08-28T13:08:14.4604771Z Reading package lists... 45%
2023-08-28T13:08:14.4605711Z
2023-08-28T13:08:14.4605829Z Reading package lists... 45%
2023-08-28T13:08:14.4605985Z
2023-08-28T13:08:14.4606100Z Reading package lists... 45%
2023-08-28T13:08:14.4608987Z
2023-08-28T13:08:14.4609123Z Reading package lists... 46%
2023-08-28T13:08:14.4609291Z
2023-08-28T13:08:14.4609397Z Reading package lists... 57%
2023-08-28T13:08:14.4609555Z
2023-08-28T13:08:14.4609663Z Reading package lists... 57%
2023-08-28T13:08:14.4609819Z
2023-08-28T13:08:14.4609925Z Reading package lists... 67%
2023-08-28T13:08:14.4610080Z
2023-08-28T13:08:14.4610184Z Reading package lists... 67%
2023-08-28T13:08:14.4610339Z
2023-08-28T13:08:14.4610430Z Reading package lists... 72%
2023-08-28T13:08:14.4610587Z
2023-08-28T13:08:14.4610691Z Reading package lists... 72%
2023-08-28T13:08:14.4610842Z
2023-08-28T13:08:14.4610950Z Reading package lists... 72%
2023-08-28T13:08:14.4611106Z
2023-08-28T13:08:14.4611210Z Reading package lists... 72%
2023-08-28T13:08:14.4611364Z
2023-08-28T13:08:14.4611487Z Reading package lists... 72%
2023-08-28T13:08:14.4611643Z
2023-08-28T13:08:14.4611747Z Reading package lists... 72%
2023-08-28T13:08:14.4612823Z
2023-08-28T13:08:14.4612960Z Reading package lists... 72%
2023-08-28T13:08:14.4613131Z
2023-08-28T13:08:14.4613250Z Reading package lists... 72%
2023-08-28T13:08:14.4613425Z
2023-08-28T13:08:14.4613544Z Reading package lists... 82%
2023-08-28T13:08:14.4613717Z
2023-08-28T13:08:14.4613836Z Reading package lists... 82%
2023-08-28T13:08:14.4614009Z
2023-08-28T13:08:14.4614126Z Reading package lists... 92%
2023-08-28T13:08:14.4614301Z
2023-08-28T13:08:14.4614419Z Reading package lists... 92%
2023-08-28T13:08:14.4614592Z
2023-08-28T13:08:14.4614710Z Reading package lists... 96%
2023-08-28T13:08:14.4614870Z
2023-08-28T13:08:14.4614989Z Reading package lists... 96%
2023-08-28T13:08:14.4615161Z
2023-08-28T13:08:14.4615279Z Reading package lists... 96%
2023-08-28T13:08:14.4615605Z
2023-08-28T13:08:14.4615722Z Reading package lists... 96%
2023-08-28T13:08:14.4616541Z
2023-08-28T13:08:14.4616840Z Reading package lists... 98%
2023-08-28T13:08:14.4617009Z
2023-08-28T13:08:14.4617119Z Reading package lists... 98%
2023-08-28T13:08:14.4617282Z
2023-08-28T13:08:14.4617397Z Reading package lists... Done
2023-08-28T13:08:14.4617730Z
2023-08-28T13:08:14.4617832Z Building dependency tree... 0%
2023-08-28T13:08:14.4618165Z
2023-08-28T13:08:14.4618275Z Building dependency tree... 0%
2023-08-28T13:08:14.4618436Z
2023-08-28T13:08:14.4618546Z Building dependency tree... 50%
2023-08-28T13:08:14.4618708Z
2023-08-28T13:08:14.4618817Z Building dependency tree... 50%
2023-08-28T13:08:14.4618980Z
2023-08-28T13:08:14.4619087Z Building dependency tree... 73%
2023-08-28T13:08:14.4619246Z
2023-08-28T13:08:14.4619356Z Building dependency tree
2023-08-28T13:08:14.4619514Z
2023-08-28T13:08:14.4619627Z Reading state information... 0%
2023-08-28T13:08:14.4619773Z
2023-08-28T13:08:14.4619884Z Reading state information... 0%
2023-08-28T13:08:14.4620231Z
2023-08-28T13:08:14.4620374Z Reading state information... Done
2023-08-28T13:08:14.4620689Z The following additional packages will be installed:
2023-08-28T13:08:14.4621120Z python3-software-properties
2023-08-28T13:08:14.4621382Z Recommended packages:
2023-08-28T13:08:14.4621646Z unattended-upgrades
2023-08-28T13:08:14.4621924Z The following NEW packages will be installed:
2023-08-28T13:08:14.4622343Z python3-software-properties software-properties-common
2023-08-28T13:08:14.4622721Z 0 upgraded, 2 newly installed, 0 to remove and 8 not upgraded.
2023-08-28T13:08:14.4623026Z Need to get 32.0 kB of archives.
2023-08-28T13:08:14.4623351Z After this operation, 334 kB of additional disk space will be used.
2023-08-28T13:08:14.4623646Z �[33m
2023-08-28T13:08:14.4623877Z 0% [Working]�[0m
2023-08-28T13:08:14.4624197Z
2023-08-28T13:08:14.4624945Z Err:1 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 python3-software-properties all 0.99.9.11
2023-08-28T13:08:14.4625572Z 404 Not Found [IP: 185.125.190.36 80]
2023-08-28T13:08:14.4626134Z �[33m
2023-08-28T13:08:14.4626395Z 0% [Working]�[0m
2023-08-28T13:08:14.4626625Z
2023-08-28T13:08:14.4627162Z Err:2 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 software-properties-common all 0.99.9.11
2023-08-28T13:08:14.4627760Z 404 Not Found [IP: 185.125.190.36 80]
2023-08-28T13:08:14.4628162Z �[33m
2023-08-28T13:08:14.4628398Z 0% [Working]�[0m
2023-08-28T13:08:14.4628607Z
2023-08-28T13:08:14.4629424Z �[1;31mE: �[0mFailed to fetch http://archive.ubuntu.com/ubuntu/pool/main/s/software-properties/python3-software-properties_0.99.9.11_all.deb 404 Not Found [IP: 185.125.190.36 80]�[0m
2023-08-28T13:08:14.4630559Z �[1;31mE: �[0mFailed to fetch http://archive.ubuntu.com/ubuntu/pool/main/s/software-properties/software-properties-common_0.99.9.11_all.deb 404 Not Found [IP: 185.125.190.36 80]�[0m
2023-08-28T13:08:14.4631400Z �[1;31mE: �[0mUnable to fetch some archives, maybe run apt-get update or try with --fix-missing?�[0m
2023-08-28T13:08:14.4631961Z ./.github/workflows/add_sources.sh: line 3: add-apt-repository: command not found
2023-08-28T13:08:14.4632626Z 65 packages can be upgraded. Run 'apt list --upgradable' to see them.
2023-08-28T13:08:14.4633703Z ##[endgroup]
2023-08-28T13:08:14.4634073Z �[32m'before_init' returned with code '0' after 0 min 6 sec�[0m |
I pushed a commit which I think fixed the CI build. The only thing left is unit tests before this can be merged. |
…r plugin config struct
65fa870
to
8940195
Compare
8940195
to
7369172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending that the pipeline passes
This PR adds another constructor and
loadConfig
method to the task composer plugin factory to configure it with atesseract_common::TaskComposerPluginInfo
struct. This makes it easier to programmatically configure a plugin loader (e.g., from a GUI representation of a task composer graph/task)