Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Removed unused CMake option from task composer #362

Closed
wants to merge 1 commit into from

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented Aug 17, 2023

No description provided.

@marip8
Copy link
Contributor Author

marip8 commented Aug 17, 2023

After looking a little deeper, I see that this option is in fact used elsewhere in this package. It seems like a better approach would be to look for specific motion planner targets instead and make compile definitions based on which ones are available since they are all optionally compile-able.

We need to do this with the time parameterization algorithms as well since their compilation is also optional

@Levi-Armstrong
Copy link
Contributor

After looking a little deeper, I see that this option is in fact used elsewhere in this package. It seems like a better approach would be to look for specific motion planner targets instead and make compile definitions based on which ones are available since they are all optionally compile-able.

We need to do this with the time parameterization algorithms as well since their compilation is also optional

I agree

@marip8 marip8 changed the title Removed unused CMake option from task composer Draft: Removed unused CMake option from task composer Aug 18, 2023
@marip8
Copy link
Contributor Author

marip8 commented Aug 18, 2023

Closing; see #364 for a discussion on how to resolve this issue

@marip8 marip8 closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants