Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added trajectory logger printout to trajectory checker #338

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Added trajectory logger printout to trajectory checker #338

merged 4 commits into from
Jun 23, 2023

Conversation

marrts
Copy link
Contributor

@marrts marrts commented Jun 21, 2023

This is essentially the same as tesseract-robotics/tesseract#765, but for tesseract_planning

@marrts
Copy link
Contributor Author

marrts commented Jun 21, 2023

@Levi-Armstrong, should these trajectory checking utils in tesseract_planning just make a TrajArray object and directly call the checkTrajectory method in tesseract_environment? Or should we still keep this separate? Right now it feels like duplicate code.

@Levi-Armstrong
Copy link
Contributor

Use composite version. I plan to move Tesseract Composite Instruction package to Tesseract repo and use it for joint trajectory and tool paths.

@Levi-Armstrong
Copy link
Contributor

@marrts Is this ready to review?

@marrts
Copy link
Contributor Author

marrts commented Jun 23, 2023

@marrts Is this ready to review?

Yes

@Levi-Armstrong Levi-Armstrong merged commit cdad44c into tesseract-robotics:master Jun 23, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Levi-Armstrong Levi-Armstrong Levi-Armstrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marrts @Levi-Armstrong