Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump golang version in code and ci pipeline #232

Merged
merged 1 commit into from
Oct 30, 2024
Merged

bump golang version in code and ci pipeline #232

merged 1 commit into from
Oct 30, 2024

Conversation

agbpatro
Copy link
Collaborator

Description

Bumping golang version to 1.23

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

patrickdemers6
patrickdemers6 reviewed Oct 30, 2024
View reviewed changes
go.mod
@@ -1,6 +1,6 @@
module github.com/teslamotors/fleet-telemetry

go 1.20
go 1.23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update dockerfile?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@agbpatro agbpatro merged commit be9aac1 into main Oct 30, 2024
5 checks passed
@agbpatro agbpatro deleted the bump_golang_version branch October 30, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickdemers6 patrickdemers6 patrickdemers6 left review comments

@aaronpkahn aaronpkahn aaronpkahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agbpatro @aaronpkahn @patrickdemers6