Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new types to vehicle_data proto #206

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

patrickdemers6
Copy link
Collaborator

Description

Adds types for more fields.

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

protos/vehicle_data.proto Outdated Show resolved Hide resolved
protos/vehicle_data.proto Outdated Show resolved Hide resolved
protos/vehicle_data.proto Outdated Show resolved Hide resolved
Comment on lines +221 to +222
ShiftStateN = 4;
ShiftStateD = 5;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this backwards compatible change? I guess yes, since we never used these enums until now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, backwards compatible since not yet used.

@patrickdemers6 patrickdemers6 merged commit 61e20ed into teslamotors:main Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants