Fix Unix issues #20
Merged
Fix Unix issues #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's find all the cases where we call Windows-only APIs.
The getter isn't supported on Unix. Fortunately, we don't really have to call it. While it's true that we generally want to leave the environment how we found it, virtually no user will have disabled the cursor in their terminal, so we should be fine in practive.
Console.MoveBufferArea is a Windows-only API. It's a performance optimization as regular console output is extremely slow. Fortunately, this problem doesn't even seem to exist (well, at least on macOS, because that's where I was testing) so we can just get away with doing the naive output when not running on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9. Fixes #12.