Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Update new defaults #646

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

qz267
Copy link
Contributor

@qz267 qz267 commented Sep 17, 2024

@imrannayer
Copy link
Collaborator

@qz267 is there any reason for changing defaults instead of sending values and override it in module call?

@qz267 qz267 changed the title Update new defaults [WIP] - Update new defaults Sep 17, 2024
@qz267
Copy link
Contributor Author

qz267 commented Sep 17, 2024

@qz267 is there any reason for changing defaults instead of sending values and override it in module call?

Sorry for the confusion, I was trying to surface some of my WIP changes, to ask for early feedbacks, PR title updated.

b/362377949 is the original request, I don't have strong preference about update in variables or override them in the module call, any suggestions are welcomed, thanks!

@imrannayer
Copy link
Collaborator

@qz267 I think it will be better to take alternate route instead of changing defaults in the module as this change will require all the existing user of the module to adjust code for new defaults.

@bharathkkb can u plz review?

@qz267
Copy link
Contributor Author

qz267 commented Sep 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants