feat: adding support for automatic creation of psc consumer #613
Conversation
sid-occrp
requested review from
isaurabhuttam,
imrannayer and
a team
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@imrannayer @isaurabhuttam how is my PR looking ? |
|
/gcbrun |
|
/gcbrun |
|
@sid-occrp integration test failed |
| @@ -320,15 +325,62 @@ resource "google_sql_user" "iam_account" { | |||
| deletion_policy = var.user_deletion_policy | |||
| } | |||
|
|
|||
|
|
|||
| resource "google_compute_address" "psc_ilb_consumer_address" { | |||
There was a problem hiding this comment.
For each resource that supports project argument let's explicitly provide it and not depend on inheriting from provider.
| version = "~> 9.0" | ||
|
|
||
| project_id = var.project_id | ||
| network_name = "your_network_name" |
There was a problem hiding this comment.
Looks like test failure was due to name constraints Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; Error: "name" ("your_network_name") doesn't match regexp "^(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?)$"
| network_name = "your_network_name" | |
| network_name = "sample-network" |
| resource "google_dns_managed_zone" "psc_dns_zone" { | ||
| for_each = local.psc_consumers | ||
| name = each.value.name | ||
| dns_name = each.value.dns_name | ||
| visibility = "private" | ||
| private_visibility_config { | ||
| networks { | ||
| network_url = var.psc_consumer.network_id | ||
| } | ||
| } | ||
| } | ||
|
|
||
| resource "google_dns_record_set" "a" { | ||
| for_each = local.psc_consumers | ||
| name = each.value.dns_name | ||
| managed_zone = google_dns_managed_zone.psc_dns_zone[each.value.name].name | ||
| type = "A" | ||
| ttl = 300 | ||
| rrdatas = [google_compute_address.psc_ilb_consumer_address[each.value.name].address] | ||
| } | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
@srinandan suggested we make this optional with default false
When using psc you can optionally create psc consumer for main and read replica in the specified network and subnet.