Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add files_to_exclude_in_source_dir variable to exclude unwanted… #259

Conversation

davidg251
Copy link
Contributor

… files/folder in the function package.

@davidg251 davidg251 requested a review from a team as a code owner September 5, 2024 15:11
Copy link

google-cla bot commented Sep 5, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@davidg251
Copy link
Contributor Author

Hi guys,

I am using this module to create a scheduler to trigger a cloud function written in python. As part of the local development process the __pycache__ and venv folders are created, and the creation of the zip file was failing with

error creating archive: error archiving directory: lstat /usr/local/bin/python: no such file or directory

Normally, one wants to keep the folders metioned above to test the new changes on the function. That's the reason why I created this PR, just adding the variable files_to_exclude_in_source_dir to pass to the module terraform-google-modules/event-function/google used to create the function.

Cheers!

@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody enabled auto-merge (squash) October 10, 2024 21:59
@apeabody apeabody merged commit ce9a14e into terraform-google-modules:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants