Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create_bucket flag #147

Merged
merged 5 commits into from
Nov 15, 2023
Merged

feat: add create_bucket flag #147

merged 5 commits into from
Nov 15, 2023

Conversation

DarkWanderer
Copy link
Contributor

@DarkWanderer DarkWanderer commented Sep 28, 2023

Rationale: there are cases where bucket needs particular configuration (encryption, retention,...) which the module cannot provide

closes #80

@DarkWanderer DarkWanderer requested a review from a team as a code owner September 28, 2023 15:11
@google-cla
Copy link

google-cla bot commented Sep 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@DarkWanderer DarkWanderer changed the title Add create_bucket flag to accomodate use case of existing bucket feat: add create_bucket flag Sep 28, 2023
@bharathkkb
Copy link
Member

/gcbrun

@bharathkkb bharathkkb merged commit d2b68fc into terraform-google-modules:master Nov 15, 2023
4 checks passed
@bharathkkb
Copy link
Member

Thanks for the PR @DarkWanderer

@DarkWanderer DarkWanderer deleted the bucket-create branch May 3, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for create_bucket argument.
3 participants