Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add topic kms key name variable #145

Merged
merged 7 commits into from
Nov 1, 2023
Merged

feat: add topic kms key name variable #145

merged 7 commits into from
Nov 1, 2023

Conversation

AndolsiZied
Copy link
Contributor

No description provided.

@AndolsiZied AndolsiZied requested a review from a team as a code owner September 8, 2023 14:05
@AndolsiZied AndolsiZied changed the title add topic kms key name variable feat: add topic kms key name variable Sep 8, 2023
@AndolsiZied
Copy link
Contributor Author

Hello @aaron-lane,
Is there a point missing?

@aaron-lane
Copy link
Contributor

Hi @AndolsiZied 👋🏼

I have not maintained these modules in a few years. Unfortunately, I don't know who to point you to instead, but adding a description to your pull request might help get it some attention 🤔

@AndolsiZied
Copy link
Contributor Author

Hi @bharathkkb,
To fix checkov violation CKV_GCP_83 (Ensure GCP Pub/Sub Topics are encrypted with Customer Supplied Encryption Keys (CSEK)), we have to pass a custom kms. In the current state the module does not take this as a variable. For this I created this PR to pass the KMS as a variable. Exactly like this PR

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 667c4b8 into terraform-google-modules:master Nov 1, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndolsiZied @aaron-lane @g-awmalik