Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing readme files and regenerate metadata #922

Conversation

gajdaw
Copy link

@gajdaw gajdaw commented Jun 13, 2024

No description provided.

@gajdaw gajdaw requested a review from a team as a code owner June 13, 2024 16:22
@gajdaw gajdaw force-pushed the fix-add-missing-readme-files-and-regenerate-metadata branch from 44e37ef to 70e31e5 Compare June 13, 2024 16:23
@gajdaw gajdaw changed the title wip fix: add missing readme files and regenerate metadata Jun 13, 2024
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @gajdaw

@@ -0,0 +1,74 @@
# Core Project Factory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These readme's are absent by design as these are considered internal modules. Let's remove any new readme and metadata added here and in the other two places.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathkkb Thanks for your comment. I will close this PR as it is outdated now.
If I spot any problems related to metadata, I will create a new PR.

@gajdaw gajdaw force-pushed the fix-add-missing-readme-files-and-regenerate-metadata branch from f57d40f to 95ba0f2 Compare September 2, 2024 08:15
@gajdaw gajdaw closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants