feat: vpc user to run/functions + soft deletion policy #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
/gcbrun |
apeabody
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Thanks for the contribution @diegolnasc!
Looks like we just need test coverage. Can you please add soft_delete_policy to one of the /examples, and then as appropriate extend it's integration test in test/integration
| @@ -310,6 +310,13 @@ resource "google_storage_bucket" "project_bucket" { | |||
| uniform_bucket_level_access = var.bucket_ula | |||
| public_access_prevention = var.bucket_pap | |||
|
|
|||
| dynamic "soft_delete_policy" { | |||
| for_each = var.soft_delete_policy == {} ? [] : [var.soft_delete_policy] | |||
There was a problem hiding this comment.
Suggestion only: might be clearer to have the "enabled" outcome first, by checking != {}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.