-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add local deployment instructions #1327
Open
amandakarina
wants to merge
17
commits into
terraform-google-modules:master
Choose a base branch
from
amandakarina:fix/add-local-deployment-instructions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: add local deployment instructions #1327
amandakarina
wants to merge
17
commits into
terraform-google-modules:master
from
amandakarina:fix/add-local-deployment-instructions
+439
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Caetano Colin <[email protected]>
Fixes business_unit_2 commands
add more instructions on sa.tf
amandakarina
requested review from
rjerrems,
gtsorbo,
eeaton,
sleighton2022 and
a team
as code owners
August 21, 2024 17:02
apeabody
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amandakarina
A few trivial ?
below
Co-authored-by: Andrew Peabody <[email protected]>
/gcbrun |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
amandakarina
force-pushed
the
fix/add-local-deployment-instructions
branch
from
November 12, 2024 12:10
1958866
to
5adbebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instructions to deploy foundation locally, without Source Repository and without Cloud Build.