-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(docs): Add guidance about deprecated deployment methods and intended support #1276
Merged
eeaton
merged 5 commits into
terraform-google-modules:master
from
eeaton:readme-update-deployment-options
Jun 24, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
de981e5
Add warnings about deprecated deployment methods (jenkins, CSR for ne…
eeaton d52ef7a
Merge branch 'master' into readme-update-deployment-options
eeaton 8c7938d
Add text to address #1239
eeaton b99ab33
Merge branch 'readme-update-deployment-options' of https://github.com…
eeaton a53bfea
Update README.md
eeaton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,13 +1,29 @@ | ||||||
# terraform-example-foundation | ||||||
|
||||||
This example repository shows how the CFT Terraform modules can build a secure Google Cloud foundation, following the [Google Cloud Enterprise Foundations Blueprint](https://cloud.google.com/architecture/security-foundations) (previously called the _Security Foundations Guide_). | ||||||
The supplied structure and code is intended to form a starting point for building your own foundation with pragmatic defaults that you can customize to meet your own requirements. Currently, the step 0 is manually executed. | ||||||
From step 1 onwards, the Terraform code is deployed by using either Google Cloud Build (default) or Jenkins. | ||||||
Cloud Build has been chosen by default to allow you to quickly get started without having to deploy a CI/CD tool, although it is worth noting the code can easily be executed by your preferred tool. | ||||||
The supplied structure and code is intended to form a starting point for building your own foundation with pragmatic defaults that you can customize to meet your own requirements. | ||||||
|
||||||
The intended audience of this blueprint is large enterprise organizations with a dedicated platform team responsible for deploying and maintaining their GCP environment, who is commited to separation of duties across multiple teams and managing their environment solely through version-controlled Infrastructure as Code. Smaller organizations looking for a turnkey solution might prefer other options such as [Google Cloud Setup](https://console.cloud.google.com/cloud-setup/overview) | ||||||
|
||||||
## Intended usage and support | ||||||
|
||||||
This repository is intended as an example to be forked, tweaked, and maintained in the user's own version-control system; the modules within this repository are not intended for use as remote references. | ||||||
Though this blueprint can help accelerate your foundation design and build, we assume that you have the engineering skills and teams to deploy and customize your own foundation based on your own requirements. | ||||||
|
||||||
We will support: | ||||||
- Code is semantically valid, pinned to known good versions, and passes terraform validate and lint checks | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
- All PR to this repo must pass integration tests to deploy all resources into a test environment before being merged | ||||||
- Feature requests about ease of use of the code, or feature requests that generally apply to all users, are welcome | ||||||
|
||||||
We will not support: | ||||||
- In-place upgrades from a foundation deployed with an earlier version to a more recent version, even for minor version changes, might not be feasible. Repository maintainers do not have visibility to what resources a user deploys on top of their foundation or how the foundation was customized in deployment, so we make no guarantee about avoiding breaking changes. | ||||||
- Feature requests that are specific to a single user's requirement and not representative of general best practices | ||||||
|
||||||
## Overview | ||||||
|
||||||
This repo contains several distinct Terraform projects, each within their own directory that must be applied separately, but in sequence. | ||||||
Stage `0-bootstrap` is manually executed, and subsequent stages are executed using your preferred CI/CD tool. | ||||||
|
||||||
Each of these Terraform projects are to be layered on top of each other, and run in the following order. | ||||||
|
||||||
### [0. bootstrap](./0-bootstrap/) | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: proper noun?