Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudrun): delete protection, default service names #739

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Sep 24, 2024

Two updates to Cloud Run samples

fix(cloudrun): make delete protection explicit

fixes #730

Adds deletion_protection = false to tested Cloud Run services (which fixes testing, while not adding things that aren't required for untested samples)

fix(cloudrun): update cloud run services names to unique values

fixes #164

Since most Cloud Run service samples are being updated anyway, use named services when useful, otherwise use "my-service" (don't encode product name into product instance name)

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@glasnt
Copy link
Contributor Author

glasnt commented Sep 24, 2024

/gcbrun

@glasnt
Copy link
Contributor Author

glasnt commented Sep 25, 2024

/gcbrun

@glasnt
Copy link
Contributor Author

glasnt commented Sep 26, 2024

/gcbrun

@glasnt glasnt marked this pull request as ready for review September 26, 2024 04:29
@glasnt glasnt requested review from a team as code owners September 26, 2024 04:29
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @glasnt so much for the thorough clean-up

  • addressing the deletion_protection
  • addressing the beta provider flags
  • naming!

Thank you thank you thank you!

@iennae iennae merged commit 93d1efa into main Sep 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing periodic style: default values for name parameter in Cloud Run samples
2 participants