-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudrun): delete protection, default service names #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/gcbrun |
/gcbrun |
/gcbrun |
iennae
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @glasnt so much for the thorough clean-up
- addressing the deletion_protection
- addressing the beta provider flags
- naming!
Thank you thank you thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two updates to Cloud Run samples
fix(cloudrun): make delete protection explicit
fixes #730
Adds
deletion_protection = false
to tested Cloud Run services (which fixes testing, while not adding things that aren't required for untested samples)fix(cloudrun): update cloud run services names to unique values
fixes #164
Since most Cloud Run service samples are being updated anyway, use named services when useful, otherwise use "my-service" (don't encode product name into product instance name)
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review