Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): directory specific test change pruning #669

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented May 17, 2024

Description

(includes a de minimis sample change to force a test)

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@glasnt
Copy link
Contributor

glasnt commented Oct 14, 2024

@apeabody did you plan on iterating on this one more? it's been unchanged in drafts for a while

@apeabody
Copy link
Contributor Author

@apeabody did you plan on iterating on this one more? it's been unchanged in drafts for a while

Hi @glasnt - Yeah, I think this is still valuable, just needs some more time investment to handle a few final edge cases (e.g. intermediate folders contain .tf). I think I can fit it in this quarter.

@apeabody apeabody marked this pull request as ready for review October 14, 2024 21:12
@apeabody apeabody requested review from a team as code owners October 14, 2024 21:12
@apeabody apeabody requested a review from glasnt October 14, 2024 21:13
@glasnt
Copy link
Contributor

glasnt commented Oct 15, 2024

Looks like the infra change escape is now working, but we can't easily test the rest of the logic until this code is merged (without shenanigans)

@glasnt glasnt enabled auto-merge (squash) November 4, 2024 04:44
Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in theory; cannot be tested without an actual test to validate the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants