-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): directory specific test change pruning #669
base: main
Are you sure you want to change the base?
Conversation
e8bed06
to
f774dd5
Compare
@apeabody did you plan on iterating on this one more? it's been unchanged in drafts for a while |
ccc1a32
to
02d581f
Compare
02d581f
to
ab977b0
Compare
Looks like the infra change escape is now working, but we can't easily test the rest of the logic until this code is merged (without shenanigans) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in theory; cannot be tested without an actual test to validate the logic.
Description
(includes a de minimis sample change to force a test)
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review