style: default values for name parameter in Cloud Run samples

[rogerthatdev]

TL;DR

Currently, in Cloud Run samples, the google_cloud_run_service resource uses various generic values as the name, such ascloudrun-srv, cloud-run-service-name. For the sake of consistency, these names should be either meaningful to their intended function (example) or have a default generic value (something like my-cloud-run-service).

Terraform Resources

google_cloud_run_service

Detailed design

No response

Additional information

No response

[glasnt]

Since this issue was logged, the only samples that use generic names appear to be:

• Tasks (being addressed in fix: apply style guide to run/tasks #568, incidentally)
• run/traffic_* samples
• run/*_tag_* samples

[msampathkumar]

Quick update: I was checking to know if this issues is still valid, and I found few areas to improve. So not closing this request.

noauth/main.tf:  name     = "cloudrun-srv"
..
remove_tag/main.tf:  name     = "cloudrun-srv"
secret_manager/main.tf:  name     = "cloudrun-srv-env-var-secret"
..
traffic_gradual_rollout/main.tf:  name     = "cloudrun-srv"
traffic_latest_revision/main.tf:  name     = "cloudrun-srv"
traffic_rollback/main.tf:  name     = "cloudrun-srv"
traffic_split/main.tf:  name     = "cloudrun-srv"
traffic_split_tag/main.tf:  name     = "cloudrun-srv"