fix: Remove prefix_list_ids attribute from *_with_self resouces
#324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`aws_security_group_rule` with both `self = true` and non-empty `prefix_list_ids` generates multiple (# of self + # of prefix_list_ids) rules for self and each prefix_list_ids, for example,
```terraform
resource "aws_security_group_rule" "ingress_with_self" {
security_group_id = local.this_sg_id
type = "ingress"
self = true
prefix_list_ids = ["id1", "id2"]
description = "sample"
from_port = -1
to_port = -1
protocol = "-1"
}
```
then we get the rules **not only** allow all-all from self SG, **but also** allow all-all from prefix-list `id1` and allow all-all from prefix-list `id2`.
I think this is unexpected result, `ingress_with_self` itself should only add rule to allow self SG, so remove `prefix_list_ids` attribute from `*_with_self` resouces.
SSW-SCIENTIFIC
changed the title
prefix_list_ids attribute from *_with_self resoucesprefix_list_ids attribute from *_with_self resouces
|
Same thing with Edit : Open #325 for this |
3 tasks
|
This PR has been automatically marked as stale because it has been open 30 days |
|
@antonbabenko @bryantbiggs We are still blocking for production, we are waiting for this update |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This PR was automatically closed because of stale in 10 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aws_security_group_rulewith bothself = trueand non-emptyprefix_list_idsgenerates multiple (# of self + # of prefix_list_ids) rules for self and each prefix_list_ids, for example,then we get the rules not only allow all-all from self SG, but also allow all-all from prefix-list
id1and allow all-all from prefix-listid2. I think this is unexpected result,ingress_with_selfitself should only add rule to allow self SG, so removeprefix_list_idsattribute from*_with_selfresouces.Motivation and Context
Described as above.
Breaking Changes
This change avoid creating SG rules allow all-all from each prefix-list, this is breaking change.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request