You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecation warnings around resolve_conflicts, change to resolve_conflicts_on_create and resolve_conflicts_on_update
Motivation and Context
â Warning: Argument is deprecated
â
â with module.eks_cluster.module.eks.aws_eks_addon.this["kube-proxy"],
â on .terraform/modules/eks_cluster.eks/main.tf line 392, in resource "aws_eks_addon" "this":
â 392: resolve_conflicts = try(each.value.resolve_conflicts, "OVERWRITE")
â
â The "resolve_conflicts" attribute can't be set to "PRESERVE" on initial resource creation. Use "resolve_conflicts_on_create" and/or "resolve_conflicts_on_update" instead
Breaking Changes
Unknown!
How Has This Been Tested?
I have tested these changes in my current environment and deprecation warnings no longer present.
johnbr
changed the title
split up deprecated resolve_conflicts to resolve_conflicts_on_create|…
fix: split up deprecated resolve_conflicts to resolve_conflicts_on_create|…
Jul 11, 2023
johnbr
changed the title
fix: split up deprecated resolve_conflicts to resolve_conflicts_on_create|…
fix: Split deprecated resolve_conflicts to resolve_conflicts_on_create/update
Jul 11, 2023
you can pin the version of the AWS provider you use to < 5.0 if you are not using any features in 5.0. Unfortunately, Terraform does not provide a way to silence warnings at this time. Both methods are still perfectly valid, the warning is just stating that resolve_conflicts will be removed in v6.0 of the AWS provider which would be roughly a year from now
TPXP
added a commit
to TPXP/terraform-aws-eks
that referenced
this pull request
Jul 21, 2023
…ing AWS provider version to <5.0
Since we don't want to bump the AWS provider version we're using, let's add a constraint the other way to avoid the warning.
ref: terraform-aws-modules#2680
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
johnbr
changed the title
Description
Deprecation warnings around resolve_conflicts, change to resolve_conflicts_on_create and resolve_conflicts_on_update
Motivation and Context
â Warning: Argument is deprecated
â
â with module.eks_cluster.module.eks.aws_eks_addon.this["kube-proxy"],
â on .terraform/modules/eks_cluster.eks/main.tf line 392, in resource "aws_eks_addon" "this":
â 392: resolve_conflicts = try(each.value.resolve_conflicts, "OVERWRITE")
â
â The "resolve_conflicts" attribute can't be set to "PRESERVE" on initial resource creation. Use "resolve_conflicts_on_create" and/or "resolve_conflicts_on_update" instead
Breaking Changes
Unknown!
How Has This Been Tested?
I have tested these changes in my current environment and deprecation warnings no longer present.